Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move arrow_cast to datafusion-functions crate #9287

Closed
Tracked by #9285
alamb opened this issue Feb 20, 2024 · 1 comment · Fixed by #9610
Closed
Tracked by #9285

Move arrow_cast to datafusion-functions crate #9287

alamb opened this issue Feb 20, 2024 · 1 comment · Fixed by #9610
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Feb 20, 2024

Is your feature request related to a problem or challenge?

Part of #9285 and #8045

The goal is to extract function definitions out of the datafusion core.

This ticket also has the nice benefit of being able to show off the newly added API in #8985

Describe the solution you'd like

Move the arrow_cast function to datafusion-functions

Describe alternatives you've considered

Note arrow_cast is somewhat different than most functions as it is implemented as part of sql parsing rather than as a normal BuiltinFunction. This means that the rest
of datafusion sees it as an Expr::Cast which has special case handling.

We may need to add some way to for ScalarUDFs to simplify themselves (in this case for ArrowCast to "unwrap" itself).

Additional context

No response

@alamb
Copy link
Contributor Author

alamb commented Feb 20, 2024

I think #9289 would allow us to preserve the same cast semantics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant