Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a WindowUDFImpl::simplfy() API #9527

Closed
alamb opened this issue Mar 10, 2024 · 3 comments · Fixed by #9906
Closed

Add a WindowUDFImpl::simplfy() API #9527

alamb opened this issue Mar 10, 2024 · 3 comments · Fixed by #9906
Assignees
@guojidan
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Mar 10, 2024 •
edited
Loading

Is your feature request related to a problem or challenge?

For the same reasons as described for ScalarUDFImpl on #9289 we should allow user defined window functions to provide simplification rules

Describe the solution you'd like

Add WindowUdfImpl::simplify, following the model @jayzhan211 made in
#9304

Describe alternatives you've considered

No response

Additional context

No response
@alamb alamb added the enhancement New feature or request label Mar 10, 2024
This was referenced Mar 10, 2024
Open
Merged
@guojidan
Copy link
Contributor

take

@guojidan
Copy link
Contributor

let me try 😄

@alamb
Copy link
Contributor Author

alamb commented Mar 29, 2024

Thanks! My suggestion is to start this project with an example of how to use simplify (aka write the test first)

@guojidan guojidan mentioned this issue Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guojidan guojidan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: Add a WindowUDFImpl::simplify() API guojidan/arrow-datafusion
2 participants
@alamb @guojidan