Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus reporter always listen 9090 ignore config file. #2361

Closed
ev1lQuark opened this issue Jul 19, 2023 · 1 comment
Closed

Prometheus reporter always listen 9090 ignore config file. #2361

ev1lQuark opened this issue Jul 19, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ev1lQuark
Copy link
Contributor

Environment

  • Server: Dubbo-go, main branch
  • Client: Dubbo-go, main branch
  • Protocol: Triple
  • Registry: zk

Issue description

Metrics module starts reporter twice.

The first time during config loading, Prometheus reporter tries to listening 9091 in expect. (9091 is set in config file)
The second time during filter init, Prometheus reporter tries to listen 9090 as the default value.

Logs

Click me to check logs
2023-07-19 14:58:16     WARN    prometheus/reporter.go:94       new prometheus reporter with error = listen tcp :9090: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.

Config File

Click me to check files
dubbo:
  application:
    version: 3.0.1
  metrics:
    enable: true # default is true
    path: /metrics # default is /metrics
    summary-max-age: 60000000000 # 1 minute, default is 10min
    port: 9091 # default is 9090
  registries:
    myzk:
      protocol: zookeeper
      address: localhost:2181
  protocols:
    triple:
      name: tri
      port: 20000
  logger:
    zap-config:
      level: debug
  provider:
    services:
      GreeterProvider:
        group: dubbo-go
@zhaoyunxing92 zhaoyunxing92 self-assigned this Jul 19, 2023
@zhaoyunxing92 zhaoyunxing92 added the bug Something isn't working label Jul 19, 2023
@ev1lQuark
Copy link
Contributor Author

Fixed by #2392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants