Merge branch feature-metrics #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # go.mod # go.sum
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
- Coverage 44.81% 44.30% -0.52%
==========================================
Files 299 304 +5
Lines 18270 18528 +258
==========================================
+ Hits 8188 8209 +21
- Misses 9224 9457 +233
- Partials 858 862 +4
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM. |
FinalT
approved these changes
Aug 4, 2023
|
LGTM. |
ev1lQuark
approved these changes
Aug 4, 2023
|
LGTM |
AlexStocks
reviewed
Aug 4, 2023
| @@ -31,6 +32,7 @@ import ( | |||
| ) | |||
|
|
|||
| var localIp string | |||
There was a problem hiding this comment.
如果有多个 var 写在一块，要写成
“ var (
)”
这种形式
AlexStocks
reviewed
Aug 4, 2023
| "dubbo.apache.org/dubbo-go/v3/metrics/util/aggregate" | ||
| ) | ||
|
|
||
| var registries = make(map[string]func(*ReporterConfig) MetricRegistry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge feature-metrics branch into master