Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Panic caused by failure to connect to the peer when obtaining remote metadata #2651

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

FoghostCn
Copy link
Contributor

@FoghostCn FoghostCn commented Apr 3, 2024

fix #2650
fix Panic caused by failure to connect to the peer when obtaining remote metadata

The callback function of the registration center will not be interrupted when an error occurs in obtaining remote metadata.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 47.38%. Comparing base (2f5143a) to head (e5e3b00).
Report is 4 commits behind head on main.

❗ Current head e5e3b00 differs from pull request most recent head 45be6f7. Consider uploading reports for the commit 45be6f7 to get more accurate results

Files Patch % Lines
...try/servicediscovery/service_discovery_registry.go 0.00% 4 Missing ⚠️
...ta/service/local/metadata_service_proxy_factory.go 0.00% 1 Missing and 1 partial ⚠️
...scovery/service_instances_changed_listener_impl.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2651   +/-   ##
=======================================
  Coverage   47.38%   47.38%           
=======================================
  Files         341      341           
  Lines       25122    25131    +9     
=======================================
+ Hits        11904    11909    +5     
+ Misses      12074    12071    -3     
- Partials     1144     1151    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FoghostCn FoghostCn marked this pull request as ready for review April 6, 2024 07:35
@FoghostCn FoghostCn marked this pull request as draft April 8, 2024 03:57
@FoghostCn FoghostCn marked this pull request as ready for review April 8, 2024 11:24
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.6% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit f04c8d0 into apache:main Apr 29, 2024
5 checks passed
@FoghostCn FoghostCn deleted the bug-fix-metadata branch April 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

有一个panic导致应用挂了
3 participants