-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @author rule in checkstyle #2317
Comments
Agree with this proposal.
|
I notice the checkstyle is skip since 81c3c0d |
@htynkn |
@htynkn I suggest running checkstyle and rat plugin during release phase. For daily travis ci, just running mvn test, it needs to be completed ASAP. Now the ci task takes a bit long time. |
An approach I have seen taken in other projects is to remove @author tags but move the names to the appropriate POM section (if they are not already present). |
I've enabled checkstyle and rat plugin for default travis CI. |
According to code-conventions, "@ author" tag is not allow in source code.
I notice some PR and some test code still have "@ author" tag, considering we already have checkstyle plugin, I suggest add a new rule to check @ author tag. it can save time to review PR.
Some configuration sample:
https://github.com/danielb987/EmojicodeEditor/blob/master/checkstyle/emojicode_checks.xml#L93
The text was updated successfully, but these errors were encountered: