Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the schedule frequency of HeartbeatTask. #2537

Closed
chickenlj opened this issue Sep 20, 2018 · 3 comments
Closed

Increase the schedule frequency of HeartbeatTask. #2537

chickenlj opened this issue Sep 20, 2018 · 3 comments

Comments

@chickenlj
Copy link
Contributor

Here is how heartbeat works in Dubbo:
Heartbeat scheduler will schedule HeartbeatTask in every heartbeat time, when being scheduled, HeartbeatTask will internally continue to check the necessity of sending a heartbeat event (only send when it find that the idle interval >heartbeat).
Consider different combinations of these two intervals: schedule interval and idle interval, we may have a chance of idle for 2*heartbeat on a wire without any request/response or heartbeat event being sent.

Though the timeout interval in Dubbo is 3*heartbeat, and 2*heartbeat idle would not mislead Dubbo to terminate the connection, we may need to increase the frequency of the scheduler to make it more accurate.

@carryxyh
Copy link
Member

Hi, I will start a work on it.
I plan to use hashwheeltimer to make each client's heartbeat more frequent.
What's your opinion?

@carryxyh
Copy link
Member

Close via #2658.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants