From 4ebdbb634cd6544b6e6dfaed0341cce0b6fcf923 Mon Sep 17 00:00:00 2001 From: He Wang Date: Sun, 4 Jun 2023 20:19:26 +0800 Subject: [PATCH] comments addressed --- .../ververica/cdc/connectors/oceanbase/OceanBaseSource.java | 2 +- .../oceanbase/source/OceanBaseRichSourceFunction.java | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/OceanBaseSource.java b/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/OceanBaseSource.java index 15a57304c5..3f985dbfe6 100644 --- a/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/OceanBaseSource.java +++ b/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/OceanBaseSource.java @@ -187,7 +187,7 @@ public SourceFunction build() { && (StringUtils.isNotEmpty(databaseName) || StringUtils.isNotEmpty(tableName))) { throw new IllegalArgumentException( - "'database-name' and 'table-name' should be configured with 'INITIAL' mode"); + "If startup mode is not 'INITIAL', 'database-name' and 'table-name' must not be configured"); } if (StringUtils.isNotEmpty(databaseName) || StringUtils.isNotEmpty(tableName)) { if (StringUtils.isEmpty(databaseName) || StringUtils.isEmpty(tableName)) { diff --git a/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/source/OceanBaseRichSourceFunction.java b/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/source/OceanBaseRichSourceFunction.java index 58e9db2b8a..64df710c4d 100644 --- a/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/source/OceanBaseRichSourceFunction.java +++ b/flink-connector-oceanbase-cdc/src/main/java/com/ververica/cdc/connectors/oceanbase/source/OceanBaseRichSourceFunction.java @@ -225,7 +225,11 @@ private void initTableWhiteList() { LOG.info("Pattern matched tables: {}", matchedTables); localTableSet.addAll(matchedTables); } catch (SQLException e) { - LOG.error("Query table list by 'databaseName' and 'tableName' failed", e); + LOG.error( + String.format( + "Query table list by 'database-name' %s and 'table-name' %s failed.", + databaseName, tableName), + e); throw new FlinkRuntimeException(e); } }