Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type test is not supported in pr title #1575

Open
LeslieKid opened this issue Oct 3, 2024 · 0 comments
Open

Type test is not supported in pr title #1575

LeslieKid opened this issue Oct 3, 2024 · 0 comments

Comments

@LeslieKid
Copy link
Contributor

Describe This Problem

I encountered an error in pr #1573 when run Checks check-pr-title:
PR title does not follow the convention, the pattern: ^(feat|fix|docs|refactor|chore)((.+))?!?: .+$
because the pr title is test: add integration test for compaction offload, not match patter above.

But I found that test type is supported when reading convential commit guide in official document. Similar situation include style and build type.

So I think these types should be supported in check-pr-title.

Proposal

If test, style and build can be supported, we can add these types in the check-pr-title part in .github/workflows/check-pr-title.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant