Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Add Jira URL and Mailing List #2404

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

wangxianghu
Copy link
Contributor

Tips

What is the purpose of the pull request

(For example: This pull request adds quick-start document.)

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codecov-io
Copy link

Codecov Report

Merging #2404 (fdeb851) into master (698694a) will decrease coverage by 40.19%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2404       +/-   ##
=============================================
- Coverage     50.23%   10.04%   -40.20%     
+ Complexity     2985       48     -2937     
=============================================
  Files           410       52      -358     
  Lines         18398     1852    -16546     
  Branches       1884      223     -1661     
=============================================
- Hits           9242      186     -9056     
+ Misses         8398     1653     -6745     
+ Partials        758       13      -745     
Flag Coverage Δ Complexity Δ
hudicli ? ?
hudiclient ? ?
hudicommon ? ?
hudiflink ? ?
hudihadoopmr ? ?
hudisparkdatasource ? ?
hudisync ? ?
huditimelineservice ? ?
hudiutilities 10.04% <ø> (-59.62%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...va/org/apache/hudi/utilities/IdentitySplitter.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...va/org/apache/hudi/utilities/schema/SchemaSet.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...a/org/apache/hudi/utilities/sources/RowSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
.../org/apache/hudi/utilities/sources/AvroSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../org/apache/hudi/utilities/sources/JsonSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...rg/apache/hudi/utilities/sources/CsvDFSSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-10.00%)
...g/apache/hudi/utilities/sources/JsonDFSSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...apache/hudi/utilities/sources/JsonKafkaSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...pache/hudi/utilities/sources/ParquetDFSSource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...lities/schema/SchemaProviderWithPostProcessor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
... and 387 more

@wangxianghu
Copy link
Contributor Author

@yanghua please take a look when free

Copy link
Contributor

@yanghua yanghua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanghua yanghua self-assigned this Jan 5, 2021
@yanghua
Copy link
Contributor

yanghua commented Jan 5, 2021

@vinothchandar Do you agree with this change?

@nsivabalan nsivabalan merged commit 7b2e658 into apache:master Jan 28, 2021
@vinothchandar
Copy link
Member

yes. thanks @wangxianghu !

@wangxianghu wangxianghu deleted the jira-mailing-list branch January 19, 2022 12:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.22%. Comparing base (698694a) to head (fdeb851).
Report is 4557 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2404      +/-   ##
============================================
- Coverage     50.23%   50.22%   -0.02%     
  Complexity     2985     2985              
============================================
  Files           410      410              
  Lines         18398    18398              
  Branches       1884     1884              
============================================
- Hits           9242     9240       -2     
- Misses         8398     8399       +1     
- Partials        758      759       +1     
Flag Coverage Δ
hudicli 37.28% <ø> (ø)
hudiclient ∅ <ø> (∅)
hudicommon 51.78% <ø> (-0.03%) ⬇️
hudiflink 10.20% <ø> (ø)
hudihadoopmr 33.35% <ø> (ø)
hudisparkdatasource 62.81% <ø> (ø)
hudisync 48.71% <ø> (ø)
huditimelineservice 65.30% <ø> (ø)
hudiutilities 69.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants