Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORT] Performance degradation for listing partitions #5776

Closed
namuny opened this issue Jun 7, 2022 · 3 comments
Closed

[SUPPORT] Performance degradation for listing partitions #5776

namuny opened this issue Jun 7, 2022 · 3 comments
Assignees
Labels
priority:critical production down; pipelines stalled; Need help asap.

Comments

@namuny
Copy link

namuny commented Jun 7, 2022

I'm noticing a steep increase in duration for listing partitions during clustering (and potentially for other operations such as clean, haven't tested this yet), specifically after this PR was merged. I'm yet to get to the bottom of exactly why, but reverting the implementation of FileSystemBackedTableMetadata.getAllPartitionPaths to 0.9.0's implementation gives me a performance boost.

Test results:

  • 0.9.0 approach (but using 0.11.0 for everything else) - 50 seconds to list partitions
  • Pure 0.11.0 approach - over 20 minutes to list partitions

My setup:

  • Hudi 0.11.0
  • CoW + inline clustering
  • Metadata table is disabled
  • Test results above is with 10,000 partitions, using S3.

Regardless of why the metadata is disabled, I'm curious to understand why the partition listing time for 10,000 partitions goes from sub minute to 20+ minutes.

Expected behavior

There should not be a performance degradation when listing partitions for operations such as clustering.

Environment Description

  • Hudi version : 0.11.0

  • Spark version : 3.1.2

  • Storage (HDFS/S3/GCS..) : S3

  • Running on Docker? (yes/no) : No

@nsivabalan nsivabalan added the priority:critical production down; pipelines stalled; Need help asap. label Jun 7, 2022
@nsivabalan
Copy link
Contributor

@namuny : yes, looks like it regressed. https://issues.apache.org/jira/browse/HUDI-4221
I am reverting the change. will put up a PR.

@nsivabalan
Copy link
Contributor

#5829

@nsivabalan nsivabalan self-assigned this Jun 10, 2022
@nsivabalan
Copy link
Contributor

thanks for pointing it out. since we have a PR, closing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:critical production down; pipelines stalled; Need help asap.
Projects
None yet
Development

No branches or pull requests

2 participants