Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to pickle the Catalog #514

Open
Fokko opened this issue Mar 11, 2024 · 6 comments
Open

Ability to pickle the Catalog #514

Fokko opened this issue Mar 11, 2024 · 6 comments

Comments

@Fokko
Copy link
Contributor

Fokko commented Mar 11, 2024

Feature Request / Improvement

This allows distribution of the Catalog object within Ray.

@kevinjqliu
Copy link
Contributor

kevinjqliu commented Mar 20, 2024

Copied from the other thread:
#513 (comment)

I was looking at Pydantic docs and it looks like there's a helpful function which supports pickling and unpickling
https://docs.pydantic.dev/latest/concepts/serialization/#pickledumpsmodel

Copy link

This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.

@github-actions github-actions bot added the stale label Sep 17, 2024
@kevinjqliu
Copy link
Contributor

@dev-goyal I see that you've merged ray-project/ray#46889 curious if you think pickling the Catalog or Table is still valuable to the Ray project

@kevinjqliu
Copy link
Contributor

More context:
ray-project/ray#42235 (comment)

@github-actions github-actions bot removed the stale label Sep 19, 2024
@dev-goyal
Copy link

dev-goyal commented Oct 2, 2024

@dev-goyal I see that you've merged ray-project/ray#46889 curious if you think pickling the Catalog or Table is still valuable to the Ray project

I think it could help, but for me - I did not find recreating the catalog each time to add much overhead. So, it will likely just make the code cleaner is all

@kevinjqliu
Copy link
Contributor

So, it will likely just make the code cleaner is all

Makes sense, the difference is directly pickling the catalog object so that it can be distributed to ray workers versus the current implementation which pass the catalog_kwargs to reconstruct the catalog at the worker node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants