Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate catalog behavior #813

Open
kevinjqliu opened this issue Jun 12, 2024 · 4 comments
Open

Consolidate catalog behavior #813

kevinjqliu opened this issue Jun 12, 2024 · 4 comments
Labels
good first issue Good for newcomers

Comments

@kevinjqliu
Copy link
Contributor

kevinjqliu commented Jun 12, 2024

Feature Request / Improvement

We should ensure consistency in catalog behaviors for all implementations.

Currently, we have a few different catalog implementations (dynamodb, glue, hive, rest, and sql).
Each catalog implementation supports a set of functions described in the Catalog ABC class (https://github.com/apache/iceberg-python/blob/main/pyiceberg/catalog/__init__.py#L276)

The behavior for each catalog implementation should be standardized. And we should test that a set of behaviors is consistent across all catalog implementations.

Here are a few related issues

Add SqlCatalog to test console #488 is an example PR that utilizes tests/cli/test_console.py to ensure the same behaviors for different catalogs.

@kevinjqliu kevinjqliu added the good first issue Good for newcomers label Jun 12, 2024
@rohithkanchukatla
Copy link

Hii Kevin, Can I take up this issue?

@kevinjqliu
Copy link
Contributor Author

@rohithkanchukatla sure thing

@soumya-ghosh
Copy link
Contributor

@kevinjqliu this can be closed as well as all tasks in this issue are completed.

@kevinjqliu
Copy link
Contributor Author

The behavior for each catalog implementation should be standardized. And we should test that a set of behaviors is consistent across all catalog implementations.

@soumya-ghosh I want to keep this issue open until we have a solution to address future updates. Ideally, there's a set of tests that will check the behavior of all the catalog implementations.

Add SqlCatalog to test console #488 is an example PR that utilizes tests/cli/test_console.py to ensure the same behaviors for different catalogs.

A possible solution is to test the input and expected output via the CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants