Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move _determine_partitions to pyarrow.py #896

Closed
Fokko opened this issue Jul 5, 2024 · 3 comments · Fixed by #906
Closed

Move _determine_partitions to pyarrow.py #896

Fokko opened this issue Jul 5, 2024 · 3 comments · Fixed by #906
Assignees
@soumya-ghosh
Labels
good first issue Good for newcomers
Milestone
PyIceberg 0.7.0 r...

Comments

@Fokko
Copy link
Contributor

Fokko commented Jul 5, 2024

Feature Request / Improvement

It relies heavily on PyArrow, so it should be in pyarrow.py as suggested by @HonahX in #569 (comment)
@Fokko Fokko added the good first issue Good for newcomers label Jul 5, 2024
@Fokko Fokko mentioned this issue Jul 5, 2024
Merged
@soumya-ghosh
Copy link
Contributor

@Fokko could I pick this up?

@Fokko
Copy link
Contributor Author

Fokko commented Jul 5, 2024

@soumya-ghosh Sure thing! 🙌

@soumya-ghosh soumya-ghosh mentioned this issue Jul 9, 2024
Merged
@soumya-ghosh
Copy link
Contributor

@Fokko PR #906 is ready for review.

@HonahX HonahX added this to the PyIceberg 0.7.0 release milestone Jul 11, 2024
@HonahX HonahX linked a pull request Jul 11, 2024 that will close this issue
Move determine_partitions and helper methods to io.pyarrow #906
Merged
@HonahX HonahX closed this as completed Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soumya-ghosh soumya-ghosh

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
PyIceberg 0.7.0 release
Development

Successfully merging a pull request may close this issue.

Move determine_partitions and helper methods to io.pyarrow soumya-ghosh/iceberg-python
3 participants
@Fokko @soumya-ghosh @HonahX