Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OAuth Support for iceberg rest client. #238

Closed
liurenjie1024 opened this issue Mar 9, 2024 · 5 comments · Fixed by #254
Closed

Add OAuth Support for iceberg rest client. #238

liurenjie1024 opened this issue Mar 9, 2024 · 5 comments · Fixed by #254
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@liurenjie1024
Copy link
Collaborator

The rest catalog openapi spec could be found here: https://github.com/apache/iceberg/blob/a582968975dd30ff4917fbbe999f1be903efac02/open-api

Python rest catalog client implementation could be found here:
https://github.com/apache/iceberg-python/blob/b026c5d4b7ba5244f67733870c06c952923e6852/pyiceberg/catalog/rest.py

@TennyZhuang
Copy link
Contributor

I’ll take a look on the issue

@liurenjie1024 liurenjie1024 added the good first issue Good for newcomers label Mar 9, 2024
@TennyZhuang
Copy link
Contributor

The python implementation is generated by their spec, do we really need to implement the rest client manually?

@TennyZhuang
Copy link
Contributor

I'm ready to give it a try using some OpenAPI rust generators to create a client. If anyone has tried this before and encountered any issues, feel free to share them with me.

@liurenjie1024
Copy link
Collaborator Author

The python implementation is generated by their spec, do we really need to implement the rest client manually?

Hi, are you looking at iceberg-python or generated Python module in iceberg repo? Codes in iceberg repo are only used for testing what's the model looks like and not used in production. The actual implementation could be found in link I mentioned above.

@liurenjie1024
Copy link
Collaborator Author

I'm ready to give it a try using some OpenAPI rust generators to create a client. If anyone has tried this before and encountered any issues, feel free to share them with me.

We already have a rest client in catalog/rest directory, you can take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants