ORC: Upgrade to 1.7.4 (#4573)

apache · May 13, 2022 · 32841a2 · 32841a2
1 parent 9db76b5
commit 32841a2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java b/data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java
@@ -305,7 +305,16 @@ public void testIsNaN() {
     Assert.assertTrue("Should read: NaN counts are not tracked in Parquet metrics", shouldRead);
 
     shouldRead = shouldRead(isNaN("no_nans"));
-    Assert.assertTrue("Should read: NaN counts are not tracked in Parquet metrics", shouldRead);
+    switch (format) {
+      case ORC:
+        Assert.assertFalse("Should read 0 rows due to the ORC filter push-down feature", shouldRead);
+        break;
+      case PARQUET:
+        Assert.assertTrue("Should read: NaN counts are not tracked in Parquet metrics", shouldRead);
+        break;
+      default:
+        throw new UnsupportedOperationException("Row group filter tests not supported for " + format);
+    }
 
     shouldRead = shouldRead(isNaN("all_nulls"));
     Assert.assertFalse("Should skip: all null column will not contain nan value", shouldRead);

diff --git a/versions.props b/versions.props
@@ -5,7 +5,7 @@ org.apache.flink:* = 1.14.3
 org.apache.hadoop:* = 2.7.3
 org.apache.hive:* = 2.3.8
 org.apache.httpcomponents.client5:* = 5.1
-org.apache.orc:* = 1.7.3
+org.apache.orc:* = 1.7.4
 org.apache.parquet:* = 1.12.2
 org.apache.spark:spark-hive_2.11 = 2.4.8
 org.apache.spark:spark-avro_2.11 = 2.4.8