Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] support partition spec in iceberg python library #3228

Closed
jun-he opened this issue Oct 6, 2021 · 10 comments
Closed

[Python] support partition spec in iceberg python library #3228

jun-he opened this issue Oct 6, 2021 · 10 comments
Assignees
Labels

Comments

@jun-he
Copy link
Collaborator

jun-he commented Oct 6, 2021

No description provided.

@jun-he jun-he added the python label Oct 6, 2021
@jun-he jun-he added this to the Python 0.1.0 release milestone Oct 6, 2021
@jun-he jun-he changed the title [Python] support partition spec in iceberg python library python [Python] support partition spec in iceberg python library Oct 6, 2021
@nssalian
Copy link
Contributor

@jun-he shall I work on this?

@nssalian
Copy link
Contributor

This depends on the work in #3216 for types definition.

@jun-he
Copy link
Collaborator Author

jun-he commented Oct 20, 2021

Yep, working on #3216 and will ship it ASAP.

@nssalian
Copy link
Contributor

Thanks @jun-he for starting off the work on python with #3234. I'll use this to open a PR for the partition_spec.

@jun-he jun-he closed this as completed Oct 23, 2021
@nssalian
Copy link
Contributor

@jun-he reason for closing this?

@jun-he jun-he reopened this Oct 24, 2021
@jun-he
Copy link
Collaborator Author

jun-he commented Oct 24, 2021

Sorry, that was not intended. Reopened it.

@nssalian
Copy link
Contributor

Thanks @jun-he. I should have a PR ready sometime next week.

@samredai
Copy link
Collaborator

samredai commented Apr 11, 2022

Now that schema has been merged I think we need a couple more PRs in order to close this:

  1. PartitionField
  2. PartitionSpec
  3. PartitionSpecBuilder

For 3. I know we discussed whether we should go with the builder pattern or just lean into python's ability for named optional arguments. There might be a middle ground in there where we use the builder pattern (to maintain consistency with the java codebase) and simply use that builder in the PartitionSpec dunder init.

Anyone interested, please feel free to tackle any of these items! 😃

@dramaticlly
Copy link
Contributor

I can help by starting with PartitionSpec!

@rdblue
Copy link
Contributor

rdblue commented Jul 22, 2022

This was added in the PRs above, so I'll close this.

@rdblue rdblue closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants