From 1a873d3f00deda8be89413a25a08b1854aa8220d Mon Sep 17 00:00:00 2001 From: Alok Thatikunta Date: Sun, 21 Jan 2024 14:08:23 +0530 Subject: [PATCH 1/2] Update S3FileIO test to run when CLIENT_FACTORY is not set --- .../apache/iceberg/aws/s3/TestS3FileIOIntegration.java | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java b/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java index d244f5f374c0..97df4824a978 100644 --- a/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java +++ b/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java @@ -156,16 +156,12 @@ public void testS3FileIOWithS3FileIOAwsClientFactoryImpl() throws Exception { } @Test - public void testS3FileIOWithDefaultAwsClientFactoryImpl() throws Exception { + public void testS3FileIOWithAwsClientFactoryImpl() throws Exception { s3.putObject( PutObjectRequest.builder().bucket(bucketName).key(objectKey).build(), RequestBody.fromBytes(contentBytes)); S3FileIO s3FileIO = new S3FileIO(); - Map properties = Maps.newHashMap(); - properties.put( - S3FileIOProperties.CLIENT_FACTORY, - "org.apache.iceberg.aws.s3.DefaultS3FileIOAwsClientFactory"); - s3FileIO.initialize(properties); + s3FileIO.initialize(Maps.newHashMap()); validateRead(s3FileIO); } From bf71284ca8aa08d7ef066837619de16c9c8b683c Mon Sep 17 00:00:00 2001 From: Alok Thatikunta Date: Thu, 25 Jan 2024 21:10:15 +0530 Subject: [PATCH 2/2] Minor: revert file name --- .../java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java b/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java index 97df4824a978..389e5c82e3f6 100644 --- a/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java +++ b/aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java @@ -156,7 +156,7 @@ public void testS3FileIOWithS3FileIOAwsClientFactoryImpl() throws Exception { } @Test - public void testS3FileIOWithAwsClientFactoryImpl() throws Exception { + public void testS3FileIOWithDefaultAwsClientFactoryImpl() throws Exception { s3.putObject( PutObjectRequest.builder().bucket(bucketName).key(objectKey).build(), RequestBody.fromBytes(contentBytes));