Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReferenceBean's getObject() called in toString() #2757

Closed
beiwei30 opened this issue Nov 8, 2018 · 4 comments
Closed

ReferenceBean's getObject() called in toString() #2757

beiwei30 opened this issue Nov 8, 2018 · 4 comments

Comments

@beiwei30
Copy link
Member

beiwei30 commented Nov 8, 2018

Intellij Idea's debugger renders object to string in object view (Preferences -> Build, Execution, Deployment -> Debugger -> Data Views -> Java -> Enable 'toString()' object view). This behavior is enabled by default and it leads some strange problem when debug in Dubbo, for examples: #2431, or user may observe a ReferenceConfig may init twice or ReferenceConfig#urls may have two same entries if the breakpoint happens to set in the relevant places. You may interested in looking into the details from http://t.cn/EAhta27, where @code4wt gives the excellent analysis.

@carryxyh
Copy link
Member

carryxyh commented Nov 8, 2018

@beiwei30
How do u think about that toString method print getObject's result.
IMO, toString method should not print this info because this is meaningless.
So I support @code4wt revision.

@beiwei30
Copy link
Member Author

beiwei30 commented Nov 8, 2018

@carryxyh I like the proposed pull request from @code4wt

@code4wt
Copy link
Contributor

code4wt commented Nov 8, 2018

I like the proposed pull request from @code4wt

Thanks.

@carryxyh
Copy link
Member

carryxyh commented Nov 8, 2018

Nice pr and analysis.
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants