avoid dup refresh for registry config #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tRegistryIdsToRegistries generates invalid registry config
chickenlj
requested changes
Jan 6, 2019
| @@ -478,7 +477,7 @@ private void convertRegistryIdsToRegistries() { | |||
| } | |||
| Arrays.stream(arr).forEach(id -> { | |||
| if (registries.stream().noneMatch(reg -> reg.getId().equals(id))) { | |||
| RegistryConfig registryConfig = new RegistryConfig(); | |||
| RegistryConfig registryConfig = new RegistryConfig(RegistryConfig.NO_AVAILABLE); | |||
There was a problem hiding this comment.
I don't think we can give RegistryConfig a default value RegistryConfig.NO_AVAILABLE, instead we should leave it empty. We will try to refresh this RegistryConfig later, if the user fails to set the right item for RegistryConfig, it will receive an Exception then when checking isValid. But if we give it this default value, it will always pass isValid and does register URL to Registry Center which can be unexpected behaviour.
chickenlj
reviewed
Jan 6, 2019
| @@ -118,6 +118,8 @@ public void checkApplication2() throws Exception { | |||
| public void testLoadRegistries() throws Exception { | |||
| System.setProperty("dubbo.registry.address", "addr1"); | |||
| InterfaceConfig interfaceConfig = new InterfaceConfig(); | |||
| // FIXME: now we need to check first, then load | |||
| interfaceConfig.checkRegistry(); | |||
There was a problem hiding this comment.
Maybe we should give loadRegistries another name that can better reflect what it does. It is misleading since it loads nothing except for converts RegistryConfigs to URLs.
This was referenced Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.