Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer jax-rs annotation on impl and compatible with old version #3224

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

Jeff-Lv
Copy link
Contributor

@Jeff-Lv Jeff-Lv commented Jan 14, 2019

As Luo's advice,

The jax-rs annoations should be preferred to implemation class as the reasons below

  1. compatible to old dubbo version
  2. Dubbo REST provider can be used without using of Dubbo Conumser for REST (User may access the rest API from JS client directly).
  3. Interface should be kept clean without the pullation of REST annoatation.

@codecov-io
Copy link

Codecov Report

Merging #3224 into 2.7.0-release will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             2.7.0-release   #3224      +/-   ##
==================================================
+ Coverage            63.79%   63.8%   +0.01%     
  Complexity              75      75              
==================================================
  Files                  651     651              
  Lines                28311   28311              
  Branches              4792    4792              
==================================================
+ Hits                 18061   18064       +3     
+ Misses                7980    7976       -4     
- Partials              2270    2271       +1
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 64.75% <100%> (ø) 0 <0> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 75% <0%> (-11.12%) 0% <0%> (ø)
...che/dubbo/remoting/transport/mina/MinaChannel.java 43.42% <0%> (-10.53%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 44.79% <0%> (-3.13%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 59.82% <0%> (-0.86%) 0% <0%> (ø)
.../java/org/apache/dubbo/config/ReferenceConfig.java 59.19% <0%> (+0.36%) 0% <0%> (ø) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 72.48% <0%> (+0.67%) 0% <0%> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.82% <0%> (+0.75%) 0% <0%> (ø) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 66.1% <0%> (+0.84%) 0% <0%> (ø) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347f154...95b320c. Read the comment docs.

@chickenlj
Copy link
Contributor

LGTM

@chickenlj chickenlj added this to the 2.7.0 milestone Jan 14, 2019
@chickenlj chickenlj merged commit 8e838d5 into apache:2.7.0-release Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants