Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an empty object #3734

Merged
merged 5 commits into from
Mar 26, 2019

Conversation

fitzf
Copy link
Contributor

@fitzf fitzf commented Mar 26, 2019

What is the purpose of the change

Fixed the problem that the protocoluff protocol is not judged empty when serialized

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@fitzf fitzf changed the title fix #3727 [Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an empty object #3727 Mar 26, 2019
@fitzf fitzf changed the title [Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an empty object #3727 [Dubbo-3727] Fix NullPointerException when protocoluff protocol serializes an empty object Mar 26, 2019
@codecov-io
Copy link

Codecov Report

Merging #3734 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3734      +/-   ##
===========================================
+ Coverage     63.58%   63.6%   +0.01%     
  Complexity       71      71              
===========================================
  Files           703     703              
  Lines         31000   31000              
  Branches       5022    5022              
===========================================
+ Hits          19712   19716       +4     
- Misses         9018    9020       +2     
+ Partials       2270    2264       -6
Impacted Files Coverage Δ Complexity Δ
...n/serialize/protostuff/ProtostuffObjectOutput.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 79.52% <0%> (-1.19%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 74.14% <0%> (+1.36%) 0% <0%> (ø) ⬇️
...bo/rpc/cluster/support/FailbackClusterInvoker.java 70.49% <0%> (+3.27%) 0% <0%> (ø) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0%> (+4.34%) 0% <0%> (ø) ⬇️
...ng/exchange/support/header/HeartbeatTimerTask.java 78.94% <0%> (+5.26%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad72159...3b97be1. Read the comment docs.

@CrazyHZM
Copy link
Member

LGTM

@CrazyHZM CrazyHZM merged commit a6c8835 into apache:master Mar 26, 2019
@fitzf
Copy link
Contributor Author

fitzf commented Mar 26, 2019

@CrazyHZM Will this merge request be released in 2.7.1-RELEASE?

@CrazyHZM
Copy link
Member

@CrazyHZM Will this merge request be released in 2.7.1-RELEASE?

This merge request will be released in 2.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants