-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ASF license header #3721 #3768
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3768 +/- ##
============================================
+ Coverage 63.57% 63.58% +0.01%
Complexity 71 71
============================================
Files 704 704
Lines 31063 31063
Branches 5037 5037
============================================
+ Hits 19747 19752 +5
+ Misses 9039 9038 -1
+ Partials 2277 2273 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just add missing license header to pom.xml, shell scripts and .bat
script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is also good to check the 2.6.x branch for files possible missing headers. |
ok |
What is the purpose of the change
add ASF license header #3721
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.