Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-3795] replace hard code strings with constants in config moudule #3803

Merged
merged 1 commit into from
Apr 4, 2019
Merged

[Dubbo-3795] replace hard code strings with constants in config moudule #3803

merged 1 commit into from
Apr 4, 2019

Conversation

Duncan-tree-zhou
Copy link
Contributor

What is the purpose of the change

replace hard code strings with constants in config module.

Brief changelog

the following hard code strings had been replaced:

  • in ServiceConfig:
    "revision" -> Constants.REVISION_KEY
    "registry" -> Constants.REGISTRY_KEY
  • in RegistryConfig:
    "username" -> Constants.USERNAME_KEY
    "password" -> Constants.PASSWORD_KEY
    "file" -> Constants.FILE_KEY
    "client" -> Constants.CLIENT_KEY
  • in ReferenceConfig:
    "revision" -> Constants.REVISION_KEY
    "methods" -> Constants.METHODS_KEY
    "client" -> Constants.CLIENT_KEY
  • in ProviderConfig:
    "contextpath" -> Constants.CONTEXTPATH_KEY
    "status" -> Constants.STATUS_KEY
  • in AbstractInterfaceConfig
    "logstat" -> Constants.LOGSTAT_PROTOCOL
    "local" -> Constants.LOCAL_KEY
    "cluster" -> Constants.CLUSTER_KEY
    "proxy" -> Constants.PROXY_KEY
    "filter" -> Constants.FILE_KEY
    "listener" -> Constants.LISTENER_KEY
    "layer" -> Constants.LAYER_KEY

the following constant vars in Constants.java :

    public static final String STATUS_KEY = "status";
    public static final String CONTEXTPATH_KEY = "contextpath";
    public static final String LISTENER_KEY = "listener";
    public static final String LAYER_KEY = "layer";

    public static final String LOGSTAT_PROTOCOL = "logstat";

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

in ServiceConfig:
"revision" -> Constants.REVISION_KEY
"registry" -> Constants.REGISTRY_KEY
in RegistryConfig:
"username" -> Constants.USERNAME_KEY
"password" -> Constants.PASSWORD_KEY
"file" -> Constants.FILE_KEY
"client" -> Constants.CLIENT_KEY
in ReferenceConfig:
"revision" -> Constants.REVISION_KEY
"methods" -> Constants.METHODS_KEY
"client" -> Constants.CLIENT_KEY
in ProviderConfig:
"contextpath" -> Constants.CONTEXTPATH_KEY
"status" -> Constants.STATUS_KEY
in AbstractInterfaceConfig
"logstat" -> Constants.LOGSTAT_PROTOCOL
"local" -> Constants.LOCAL_KEY
"cluster" -> Constants.CLUSTER_KEY
"proxy" -> Constants.PROXY_KEY
"filter" -> Constants.FILE_KEY
"listener" -> Constants.LISTENER_KEY
"layer" -> Constants.LAYER_KEY

add following constant vars :
    public static final String STATUS_KEY = "status";
    public static final String CONTEXTPATH_KEY = "contextpath";
    public static final String LISTENER_KEY = "listener";
    public static final String LAYER_KEY = "layer";

    public static final String LOGSTAT_PROTOCOL = "logstat";
@Duncan-tree-zhou Duncan-tree-zhou changed the title [Dubbo-XXX] replace hard code strings with constants in config moudule [Dubbo-3795] replace hard code strings with constants in config moudule Apr 3, 2019
@Duncan-tree-zhou
Copy link
Contributor Author

related issue #3795

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the pull request

@ralf0131 ralf0131 merged commit 6d3e765 into apache:master Apr 4, 2019
@cvictory cvictory added this to the 2.7.2 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants