Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul enhancement #3963

Merged
merged 2 commits into from
May 5, 2019
Merged

Conversation

Moriadry-zz
Copy link

@Moriadry-zz Moriadry-zz commented Apr 30, 2019

What is the purpose of the change

hi, Ian @beiwei30 as we discussed in #3906, this is a follow up. we choose to use http ttl check for consul heartbeat, rather than TCP check. And this works perfectly.

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3963 into master will increase coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #3963      +/-   ##
===========================================
+ Coverage     63.89%   63.9%   +<.01%     
- Complexity       98     100       +2     
===========================================
  Files           715     715              
  Lines         31493   31505      +12     
  Branches       5074    5075       +1     
===========================================
+ Hits          20122   20132      +10     
+ Misses         9067    9063       -4     
- Partials       2304    2310       +6
Impacted Files Coverage Δ Complexity Δ
...g/apache/dubbo/registry/consul/ConsulRegistry.java 59.6% <93.75%> (+2.76%) 27 <2> (+2) ⬆️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 82.75% <0%> (-3.45%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 71.42% <0%> (-2.05%) 0% <0%> (ø)
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-1.89%) 0% <0%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 81.22% <0%> (-1.15%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (ø) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 53.94% <0%> (+10.52%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78c7509...f0ad544. Read the comment docs.

@beiwei30
Copy link
Member

beiwei30 commented May 5, 2019

LGTM. Have you tested it?

@beiwei30 beiwei30 merged commit ff50a29 into apache:master May 5, 2019
@Moriadry-zz
Copy link
Author

@beiwei30 yes, already tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants