Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native hessian merge #3966

Merged
merged 11 commits into from
May 6, 2019
Merged

native hessian merge #3966

merged 11 commits into from
May 6, 2019

Conversation

Leishunyu
Copy link
Contributor

What is the purpose of the change

#3961

Brief changelog

merge native-thrift to incubator-dubbo

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@Leishunyu
Copy link
Contributor Author

@ralf0131 can you help me review

@Leishunyu
Copy link
Contributor Author

this pr merge native-thrift and native-hessian

dubbo-all/pom.xml Outdated Show resolved Hide resolved
dubbo-distribution/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@beiwei30 beiwei30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beiwei30 beiwei30 changed the title Native thrift merge Native thrift & native hessian merge May 5, 2019
@Leishunyu Leishunyu changed the title Native thrift & native hessian merge native hessian merge May 5, 2019
dubbo-all/pom.xml Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented May 5, 2019

Codecov Report

Merging #3966 into master will decrease coverage by 0.09%.
The diff coverage is 48.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #3966     +/-   ##
===========================================
- Coverage     63.88%   63.79%   -0.1%     
  Complexity       71       71             
===========================================
  Files           722      743     +21     
  Lines         31852    32125    +273     
  Branches       5115     5120      +5     
===========================================
+ Hits          20348    20493    +145     
- Misses         9162     9284    +122     
- Partials       2342     2348      +6
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/serialize/hessian/Hessian2ObjectInput.java 0% <0%> (ø) 0 <0> (?)
...ize/hessian/serializer/java8/ZoneOffsetHandle.java 0% <0%> (ø) 0 <0> (?)
...dubbo/serialize/hessian/Hessian2Serialization.java 0% <0%> (ø) 0 <0> (?)
.../dubbo/serialize/hessian/Hessian2ObjectOutput.java 0% <0%> (ø) 0 <0> (?)
...serialize/hessian/serializer/java8/YearHandle.java 54.54% <54.54%> (ø) 0 <0> (?)
...rialize/hessian/serializer/java8/ZoneIdHandle.java 54.54% <54.54%> (ø) 0 <0> (?)
...ize/hessian/serializer/java8/OffsetTimeHandle.java 58.33% <58.33%> (ø) 0 <0> (?)
...ialize/hessian/serializer/java8/InstantHandle.java 58.33% <58.33%> (ø) 0 <0> (?)
...alize/hessian/serializer/java8/MonthDayHandle.java 58.33% <58.33%> (ø) 0 <0> (?)
...hessian/serializer/java8/OffsetDateTimeHandle.java 58.33% <58.33%> (ø) 0 <0> (?)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4007cd4...b305971. Read the comment docs.

@beiwei30 beiwei30 merged commit 77df9d7 into apache:master May 6, 2019
@Leishunyu Leishunyu deleted the native-thrift branch May 6, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants