Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort added router list before set the 'routers' field of the RouterChain #3969

Merged
merged 1 commit into from
May 7, 2019

Conversation

tswstarplanet
Copy link
Contributor

What is the purpose of the change

fix a code problem

Brief changelog

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #3969 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3969      +/-   ##
============================================
+ Coverage     63.99%   63.99%   +<.01%     
  Complexity       98       98              
============================================
  Files           718      718              
  Lines         31609    31609              
  Branches       5088     5088              
============================================
+ Hits          20227    20229       +2     
+ Misses         9062     9060       -2     
  Partials       2320     2320
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/dubbo/rpc/cluster/RouterChain.java 96.87% <100%> (ø) 0 <0> (ø) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 80.07% <0%> (-2.69%) 0% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 80.14% <0%> (-0.74%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 86.2% <0%> (+3.44%) 0% <0%> (ø) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.21% <0%> (+3.57%) 0% <0%> (ø) ⬇️
...apache/dubbo/common/config/ConfigurationUtils.java 72% <0%> (+8%) 0% <0%> (ø) ⬇️
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 56.81% <0%> (+11.36%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 667f227...15b78b9. Read the comment docs.

Copy link
Contributor

@kun-song kun-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kun-song kun-song merged commit 392fcbf into apache:master May 7, 2019
@cvictory cvictory added this to the 2.7.2 milestone May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants