-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge thrift #3977
merge thrift #3977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls. check my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep the two modules[1] together for a while now.
[1] dubbo-rpc-thrift and dubbo-rpc-native-thrift
So we should upgrade the thrift version to 11
in dubbo-rpc-thrift
Codecov Report
@@ Coverage Diff @@
## master #3977 +/- ##
============================================
+ Coverage 63.68% 63.74% +0.06%
Complexity 71 71
============================================
Files 743 744 +1
Lines 32125 32205 +80
Branches 5120 5124 +4
============================================
+ Hits 20458 20529 +71
- Misses 9322 9326 +4
- Partials 2345 2350 +5
Continue to review full report at Codecov.
|
i think so, i change it |
What is the purpose of the change
#3960
Brief changelog
Cover the original thrift
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.