Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compatible] Registry compatibility #3882 #4015

Merged
merged 12 commits into from
May 17, 2019

Conversation

cvictory
Copy link
Contributor

What is the purpose of the change

fix #3882

Brief changelog

Registry compatibility: add some abstract class compatible.

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #4015 into master will decrease coverage by 0.27%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4015      +/-   ##
===========================================
- Coverage     63.47%   63.2%   -0.28%     
  Complexity      565     565              
===========================================
  Files           750     759       +9     
  Lines         32415   32908     +493     
  Branches       5145    5218      +73     
===========================================
+ Hits          20577   20799     +222     
- Misses         9480    9750     +270     
- Partials       2358    2359       +1
Impacted Files Coverage Δ Complexity Δ
...pache/dubbo/registry/support/FailbackRegistry.java 74.28% <ø> (ø) 0 <0> (ø) ⬇️
...ibaba/dubbo/registry/support/FailbackRegistry.java 0% <0%> (ø) 0 <0> (?)
...ibaba/dubbo/registry/support/AbstractRegistry.java 0% <0%> (ø) 0 <0> (?)
...ubbo/registry/support/AbstractRegistryFactory.java 0% <0%> (ø) 0 <0> (?)
.../java/com/alibaba/dubbo/common/utils/UrlUtils.java 0% <0%> (ø) 0 <0> (?)
...ava/org/apache/dubbo/common/utils/StringUtils.java 86.22% <0%> (-0.69%) 0 <0> (ø)
...ava/com/alibaba/dubbo/registry/NotifyListener.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...onfig/spring/extension/SpringExtensionFactory.java 78.04% <0%> (-7.32%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 57.14% <0%> (-5.72%) 0% <0%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0%> (-5.67%) 0% <0%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95e29a...6b58cd0. Read the comment docs.

Copy link

@Moriadry-zz Moriadry-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little request changes.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubbo registry extension compatibility with dubbo 2.6.x
4 participants