-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compatible] Registry compatibility #3882 #4015
Conversation
…boMetadataReportRetryTimer in MetadataReportRetry
…try_compatibility
...try/dubbo-registry-api/src/main/java/org/apache/dubbo/registry/support/FailbackRegistry.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4015 +/- ##
===========================================
- Coverage 63.47% 63.2% -0.28%
Complexity 565 565
===========================================
Files 750 759 +9
Lines 32415 32908 +493
Branches 5145 5218 +73
===========================================
+ Hits 20577 20799 +222
- Misses 9480 9750 +270
- Partials 2358 2359 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a little request changes.
dubbo-compatible/src/main/java/com/alibaba/dubbo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
dubbo-compatible/src/main/java/com/alibaba/dubbo/registry/support/FailbackRegistry.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
Outdated
Show resolved
Hide resolved
dubbo-compatible/src/main/java/com/alibaba/dubbo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
dubbo-compatible/src/main/java/com/alibaba/dubbo/common/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
fix #3882
Brief changelog
Registry compatibility: add some abstract class compatible.
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.