Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: clipping of lines series with dataZoom #10748

Closed
eniaclyl opened this issue Jun 26, 2019 · 16 comments
Closed

bug: clipping of lines series with dataZoom #10748

eniaclyl opened this issue Jun 26, 2019 · 16 comments
Assignees
@pissang
Labels
bug topic: dataZoom
Milestone
4.4.0

Comments

@eniaclyl
Copy link

Version

4.2.1

Reproduction link

https://gallery.echartsjs.com/editor.html?c=xCb_Xl7Zz9&comment=0

Steps to reproduce

放大后超出坐标轴的部分不会裁剪

What is expected?

超出坐标轴的部分应该裁剪

What is actually happening?

不会裁剪
@echarts-bot
Copy link

echarts-bot bot commented Jun 26, 2019

Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.

In the meanwhile, please make sure that you have posted enough image to demo your request. You may also check out the API and chart option to get the answer.

Have a nice day! 🍵

@echarts-bot echarts-bot bot added bug pending We are not sure about whether this is a bug/new feature. waiting-for-help labels Jun 26, 2019
@eniaclyl
Copy link
Author

有人帮我看看吗？提了几个类似的问题都给我关闭了，说我提的是相同的问题，你倒是告诉我答案呀！！！

@susiwen8
Copy link
Contributor

因为我也不知道答案

@eniaclyl
Copy link
Author

那你能给反馈下吗，我查过很多别人以前提的问题，散点图也有类似的bug，是不是除了线图只要使用笛卡尔坐标系都会有这个问题呀，能否告诉我在什么时候修复这个问题吗?我这个是国家电网的项目会用到你们的库

@susiwen8
Copy link
Contributor

我觉得可能是datazoom的问题，不是坐标系的问题，具体还得排查。什么时候修复就不清楚了。着急用的话个人建议先不要使用datazoom。

@eniaclyl
Copy link
Author

你这么说就确定是bug喽？如果不使用datazoom怎么缩放呀，我刚接触这个库不久，能否指点下？

@susiwen8
Copy link
Contributor

@Ovilia 你能指点下吗？

@susiwen8 susiwen8 added topic: dataZoom and removed pending We are not sure about whether this is a bug/new feature. waiting-for-help labels Jun 27, 2019
@eniaclyl
Copy link
Author

@Ovilia 大神出来指点下呗，我给你写邮件也没回我 ：(
或者告诉我计划什么时候修复这个bug也行呀，让我心里有个数。多谢

@Ovilia
Copy link
Contributor

Ovilia commented Jun 28, 2019

这个是 bug，比较难修，跟 #10646 是一样的问题。
修复的基本想法是，对 grid 区域提供一个 clip 操作，如果图形完全超出了 grid 范围，则完全不绘制（而不是用 clipPath 裁剪掉），如果一半在里面一半在外面，则 clipPath 一下。

@eniaclyl
Copy link
Author

eniaclyl commented Jul 1, 2019

@Ovilia 请问这个bug在什么时候会修复呀？下个版本吗？有没有具体修复日期和计划？

@eniaclyl
Copy link
Author

eniaclyl commented Jul 3, 2019

@Ovilia 大神能否告诉我啥时候修复这个问题吗？多谢！

@eniaclyl
Copy link
Author

@susiwen8 请问可以帮我问问什么时候修复这个不裁剪的bug吗 这关系到我们的项目是否使用echarts 谢谢

@Ovilia
Copy link
Contributor

Ovilia commented Jul 13, 2019

@eniaclyl 暂时没法安排排期，如果紧急可以自行用 hack 的方式解决

@eniaclyl
Copy link
Author

@Ovilia 请问能说说具体怎么做吗，或者给个例子也行，我是搞c++的不太懂web，我看github上很多人也问这个问题，你留个方法也方便以后的人使用，多谢了

@Ovilia Ovilia self-assigned this Jul 31, 2019
@Ovilia Ovilia changed the title 严重bug bug: clipping of lines series with dataZoom Sep 4, 2019
@Ovilia Ovilia mentioned this issue Sep 4, 2019
Closed
@Ovilia Ovilia added this to the TBD milestone Sep 4, 2019
@pissang pissang modified the milestones: TBD, 4.4.0 Sep 17, 2019
@pissang pissang assigned pissang and unassigned Ovilia Sep 17, 2019
@pissang
Copy link
Contributor

pissang commented Sep 17, 2019

Added clip option for lines series in the commit 94dfc92 . It will be included in version 4.4.0

Here is the screenshot after fixed.
image

@pissang pissang closed this as completed Sep 17, 2019
@eniaclyl
Copy link
Author

@pissang 多谢

@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
This was referenced Mar 24, 2020
Merged
Merged
@global-peach global-peach mentioned this issue May 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pissang pissang

Labels
bug topic: dataZoom
Projects
None yet
Milestone
4.4.0
Development

No branches or pull requests
4 participants
@Ovilia @pissang @susiwen8 @eniaclyl