-
Notifications
You must be signed in to change notification settings - Fork 19.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(polar): hide series bar when no data #11452
Comments
can we hava a try ? 😁 |
@foolzhang Sure! You're more than welcomed to make a pull request about this. The bar series in the polar system was introduced in #11393. I think we should not add the shape (or remove the previous shape) if the option is set to be true and the startAngle and the endAngle is the same. @pissang Is this the correct way? And do we need to remove bars in the cartesian coordinate system also? The result would be not having borders any more for zero bars. I don't think this is necessary, but just out of the uniformity. |
The main concern from me is that there will be no differences between '-' and 0 data if this option is enabled. |
|
@foolzhang You can set the |
you mean is polar:function(...){
// ...
var ShapeClass = (!isRadial && (roundCap && layout.startAngle!=layout.endAngle)) ? Sausage : graphic.Sector;
// ...
} i think this easy to satisfy your request |
Yes. We still need to add the shape, only that the fill and stroke are set to be transparent. Otherwise, it may cause error when data update since there was no previous shape. |
Merged in #11557. Thanks @foolzhang ! |
What problem does this feature solve?
For bar series in polar, it will display a circle when data value is 0. This may be strange to users if they don't know this is data 0.
Current
Expected
We should
provide an optionmake it default that the developer can choose to display nothing when data is 0.What does the proposed API look like?
No extra option.
The text was updated successfully, but these errors were encountered: