Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SaveAsImage): don't create an anchor element if you don't need to #10132

Merged
merged 1 commit into from
Mar 25, 2019
Merged

fix(SaveAsImage): don't create an anchor element if you don't need to #10132

merged 1 commit into from
Mar 25, 2019

Conversation

CarterLi
Copy link
Contributor

@CarterLi CarterLi commented Mar 19, 2019 •
edited
Loading

We won't use $a for IE and edge. In addition, there's no document object in web worker. So we'd better don't create an element if we don't need to.

Ref: #9232

@100pah 100pah merged commit afdc82c into apache:master Mar 25, 2019
@100pah
Copy link
Member

100pah commented Mar 25, 2019

Thanks @CarterLi

@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
This was referenced Mar 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100pah 100pah 100pah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarterLi @100pah