Fix #11300

[susiwen8]

For category type, one data show on window just check if scale contains it's value

Close #11300

[susiwen8]

I got problem to install puppeteer, so this PR hasn't test with test cases.

[Ovilia]

Some personal thoughts. Waiting for @100pah or @pissang to give a further CR.

[Ovilia]

_extent is a private variable. You should probably call axisX.scale.getExtent()[0] to get it.

[Ovilia]

I'm not sure if you should fix the implementation of axisX.containData in the case of one data item.

[pissang]

Hi @susiwen8 .

I think the main cause is from https://github.com/apache/incubator-echarts/blob/master/src/coord/Axis.js#L88

Current solution of containData will convert the data to coordinates, then verify if coordinates is between the axis extent. Some information will be lost during this conversion. Like coord will be clamped as you metioned in #11300 (comment)

From my perspective, a better solution is using Scale#contain

containData: function (data) {
  return this.scale.contain(data);
}

BTW: You can try using cnpm to install puppeteer. It will use Taobao Mirror to download the executable.

[susiwen8]

@pissang Hi, I have tried this.scale.contain(data), for x value is fine, but not for y value. Because yAxis' extent only consider the data not the position of markpoint.

[pissang]

Hi @susiwen8 sorry for the late reply.

Because yAxis' extent only consider the data not the position of markpoint

I didn't understand this. Did you mean value type axis?

It will be great if you can give an example to explain it. I tried using this.scale.contain(data) and it works well on the example in the issue. I think it should make sense.

[susiwen8]

@pissang Because the yAxis of markpoint for Aug and Dec are way higher than value, they aren't fit in Y axis if we use scale. Scale only consider data not markpoint.

[pissang]

Understand. I think it's another issue: If markPoint should be clipped if it exceed the axis. It should be a logic in mark point. Not in the underlying coordinate system.

But in this issue. Using this.scale.contain(data) would make more sense for the method containData.