fix(legend): fix highlight state after inverseselect #11480 #11547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pissang
approved these changes
Nov 20, 2019
100pah
reviewed
Nov 20, 2019
| @@ -238,7 +238,7 @@ export default echarts.extendComponentView({ | |||
| ); | |||
|
|
|||
| // FIXME: consider different series has items with the same name. | |||
| itemGroup.on('click', curry(dispatchSelectAction, name, api)) | |||
| itemGroup.on('click', curry(dispatchSelectAction, name, null, api, excludeSeriesId)) | |||
There was a problem hiding this comment.
The name here is "item name", but in dispatchHighlightAction and dispatchDownplayAction the first parameter is seriesName.
There was a problem hiding this comment.
The name here can be seriesName or itemName. It depends on series.
| api.dispatchAction({ | ||
| type: 'legendToggleSelect', | ||
| name: name | ||
| }); | ||
| // highlight after select | ||
| dispatchHighlightAction(name, dataName, api, excludeSeriesId); |
There was a problem hiding this comment.
This highlight action probably is not needed.
Otherwise if we call
chart.dispatchAction({
type: 'legendToggleSelect',
name: 'b'
});manually, there are still unexpected highlight state.
There was a problem hiding this comment.
I also had concerns about this.
But after run the test case. It seems to be a resonable behaviour.
100pah
added a commit
that referenced
this pull request
Nov 21, 2019
Currently the highlight state is stored in el (maybe it is inappropriate but that is another big topic). The el in oldData may be already removed prevoiusly but still has highlight state, which is unexpected. We simply do not reuse those el (detected by `!symbolEl.parent`). Check the test case in `main0` of `test/hoverStyle2.html`.
100pah
added a commit
that referenced
this pull request
Nov 21, 2019
Merged
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Item should be downplayed before unselecting.