fix(line): overflow symbols should render if clip is false #11549 #11552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pissang
approved these changes
Nov 4, 2019
pissang
requested changes
Nov 4, 2019
src/chart/line/LineView.js
Outdated
| @@ -354,7 +354,7 @@ export default ChartView.extend({ | |||
| // FIXME step not support polar | |||
| var step = !isCoordSysPolar && seriesModel.get('step'); | |||
| var clipShapeForSymbol; | |||
| if (coordSys && coordSys.getArea) { | |||
| if (coordSys && coordSys.getArea && seriesModel.get('clip')) { | |||
There was a problem hiding this comment.
It's more robust to use seriesModel.get('clip', true).
In this way it won't try get the clip property from the root option if it not exists in series.
|
Thanks a lot! I've planned it in this version. |
pissang
approved these changes
Nov 4, 2019
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11549.
before:
after:
