Add files via upload - New theme JS files #11566
Conversation
|
Thanks a lot for the contribution! |
|
You're welcome, and thanks for adding the themes! |
theme/azul.js
Outdated
| } | ||
| }, | ||
|
|
||
| k: { |
There was a problem hiding this comment.
k has been renamed to candlestick since 3.0.0
There was a problem hiding this comment.
Ok, see post on main thread. Thanks!
| color0: '#f5a503' // Yinbian border color | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The hierarchy of itemStyle since 4.0.0 has been changed to
itemStyle: {
color: ...
},
lineStyle: {
color: ...
},
areaStyle: {
color: ...
}There was a problem hiding this comment.
I'm a little confused about this. Please see post on main thread. Thanks!
theme/azul.js
Outdated
| } | ||
| }, | ||
|
|
||
| force : { |
There was a problem hiding this comment.
force has been ranamed to graph since 3.0.0
There was a problem hiding this comment.
Ok, see post on main thread. Thanks!
|
@pissang I noticed that you requested changes to the Azul theme (renamed a few elements, etc.) Most of the theme files need these changes, so I'm updating them now (local files). I'll update the files on GitHub when I'm done fixing them locally. If you see any other lines of code in the themes that need to be changed, please let me know. Thanks! |
|
@pissang I've updated all the theme JS files so that "k" is renamed as "candlestick" and "force" is renamed as "graph." For the hierarchy of itemStyle, are you saying that "normal: {....}" should be removed? For example, in azul,js, would this code be correct?: candlestick: {
itemStyle: {
color: '#f2385a',
color0: '#f5a503',
},
lineStyle: {
width: 1,
color: '#f2385a',
color0: '#f5a503',
},
areaStyle: {
color: '#eee',
color0: '#ddd'
}
},
graph: {
itemStyle: {
color: '#f2385a',
},
linkStyle: {
color: '#f2385a'
}
},
map: {
itemStyle: {
color: '#f2385a',
},
areaStyle: {
color: '#eee',
label: {
textStyle: {
color: '#c12e34'
}
}
}
},Please let me know if I've updated the code correctly in the above example. If so, I'll go through and update all the theme JS files to reflect these code changes. If you see anything else that needs to be fixed (based on azul.js). please let me know. Thanks! |
candlestick: {
itemStyle: {
color: '#f2385a',
color0: '#f5a503',
},
lineStyle: {
width: 1,
color: '#f2385a',
color0: '#f5a503',
},
areaStyle: {
color: '#eee',
color0: '#ddd'
}
},
graph: {
itemStyle: {
color: '#f2385a',
},
linkStyle: {
color: '#f2385a'
}
}These are correct. About this part. Label should be in the same level with map: {
itemStyle: {
color: '#f2385a',
},
areaStyle: {
color: '#eee'
},
label: {
color: '#c12e34'
}
},All these changes since 4.0 are trying to make |
|
Hi @pissang - Thank you for your help, I really appreciate it! I'll go through and fix all the theme files. I'll upload the fixed files to GitHub as soon as I can. It will probably take me a few days. |
Updated custom and default theme JS files, and PNG.
Add files via upload
|
Hi @pissang - I've updated the code in all the theme JS files, including five of the default themes. Some of the themes were created by other users and contributed to ECharts back when ECharts was version 2.0. For these themes, I changed as much of the code as I could. I'm not sure how to update some of the code in the older 2.0 themes. I've uploaded all the updated files to the forked repository. If I need to do anything else, please let me know. |
I've created a fork of the ECharts master, and uploaded new theme JS files to the fork. I've also included the theme screenshots for users who may not go to the ECharts website to look at the themes.
I've created this pull request per this post: #11550
I hope I've completed the pull request correctly. If I need to do something else to contribute the custom theme files to ECharts please let me know. Thanks!