fix get font configs issue #11653
Merged
fix get font configs issue #11653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original logical will never get font configs from the `textStyle` option, and also the `ecModel` doesn't have other font configs except the `textStyle` option.
`var gTextStyleModel = ecModel || ecModel.getModel('textStyle');`
Ovilia
approved these changes
Nov 15, 2019
pissang
approved these changes
Nov 15, 2019
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original logic will never get font configs from the
textStyleoption, and also theecModeldoesn't have other font configs except thetextStyleoption.