fix: #8952 callback function params.color incorrect #9238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovilia
requested changes
Oct 23, 2018
There was a problem hiding this comment.
The basic idea is correct. But this should not be done inside a getXXX function, since we most likely expect it pure. This should probably be done after https://github.com/apache/incubator-echarts/blob/d783ae2f6a86b84f926c4d2b4fd4efd236c15d9e/src/chart/sunburst/SunburstPiece.js#L95 .
|
got it. |
|
Because our project does not support babel yet. |
Ovilia
approved these changes
Oct 29, 2018
|
Hi @hling51325 , This seems to be your second PR merged. Thanks for your contribution! |
This was referenced Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe a idea, check again please