Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable services-ftp from binding #3650

Closed
1 of 3 tasks
suyanhanx opened this issue Nov 22, 2023 · 5 comments · Fixed by #3659
Closed
1 of 3 tasks

Temporarily disable services-ftp from binding #3650

suyanhanx opened this issue Nov 22, 2023 · 5 comments · Fixed by #3659

Comments

@suyanhanx
Copy link
Member

suyanhanx commented Nov 22, 2023

But due to async-rs/async-tls#55, services-ftp is still blocked on old rustls. I think we can remove it from bindings (for java/nodejs/python) until it has been resolved.

Originally posted by @Xuanwo in #3632 (comment)

Tasks

Disable the services/ftp in released bindings.

  • java
  • nodejs
  • python
@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

It's a breaking change, we should add in every binding's upgrade docs.

@suyanhanx suyanhanx changed the title Temporarily remove services-ftp from binding Temporarily disable services-ftp from binding Nov 22, 2023
@ayushkanyal
Copy link

Hey @suyanhanx , I am a beginner to open-source and would love to contribute to this project. Please let me know if you need a hand.

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

Hey @suyanhanx , I am a beginner to open-source and would love to contribute to this project. Please let me know if you need a hand.

Thank you so much! Actually, I could really use your help with this issue.

To disable services-ftp, we just need to remove services-ftp from python/java/nodejs bindings and update the upgrade.md docs.

@ZutJoe
Copy link
Contributor

ZutJoe commented Nov 23, 2023

can i try this or waiting for @ayushkanyal ?

Does updating the contents of upgrade.md just need to copy the content

@Xuanwo
Copy link
Member

Xuanwo commented Nov 23, 2023

Does updating the contents of upgrade.md just need to copy the content

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants