Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP-13-3/3: auto subscribe based on regex pattern topics changing #1175

Closed
wants to merge 7 commits into from

Conversation

zhaijack
Copy link
Contributor

@zhaijack zhaijack commented Feb 5, 2018

This change is based on work of #1165, which already contains the first 6 commits there.
In this PR, only the last commit is for this sub-task.

will update it once PIP-13-2/3 merged.

Motivation

This is a last sub-task for pip-13, which would auto subscribe new topics, based on regex pattern topics changing subscription.

Modifications

  • add TopicsChangedListener to track topics change.
  • do auto subscribe/unsubscribe based on topics changes.
  • add test cases to verify.

Result

old methods behaviour not changed,
user could use new method to subscribe to topics based on regex pattern, and do auto subscribe

@merlimat merlimat added the type/feature The PR added a new feature or issue requested a new feature label Feb 5, 2018
@merlimat merlimat added this to the 2.0.0-incubating milestone Feb 5, 2018
@zhaijack
Copy link
Contributor Author

close this for too much conflict, will open new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature The PR added a new feature or issue requested a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants