Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcc one-phase data need to be limited in size #4421

Closed
funky-eyes opened this issue Mar 1, 2022 · 3 comments · Fixed by #4473
Closed

tcc one-phase data need to be limited in size #4421

funky-eyes opened this issue Mar 1, 2022 · 3 comments · Fixed by #4473
Assignees
@Bughue
Labels
good first issue Good for newcomers task: help-wanted Extra attention is needed

Comments

@funky-eyes
Copy link
Contributor

Why you need it?

Is your feature request related to a problem? Please describe in details
tcc目前支持将一些数据保存到tc，在二阶段下发回滚或提交的时候会带下来，但是这些数据并没有进行合理的限制，导致如果盲目report大数据的话会对tc造成负担，而且对分支注册的效率也会降低，需要限制一下最大大小，老版本client没有本地判断所以需要tc端也进行判断，最佳方式是两边都加，超过大小可以抛出异常提示，这个大小允许手动配置，默认值可以设置一个相对较小的值，如128k等

How it could be?

A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.

Other related information

Add any other context or screenshots about the feature request here.
@funky-eyes funky-eyes changed the title tcc one-phase data needs to be limited in size tcc one-phase data need to be limited in size Mar 1, 2022
@funky-eyes funky-eyes added the good first issue Good for newcomers label Mar 1, 2022
@Bughue
Copy link
Contributor

Bughue commented Mar 1, 2022

plz assign to me

@funky-eyes funky-eyes added the task: help-wanted Extra attention is needed label Mar 1, 2022
@Bughue Bughue mentioned this issue Mar 15, 2022
Merged
@caohdgege
Copy link
Contributor

方案上为什么不是对APPdata进行压缩，而是选择抛异常？

@Bughue
Copy link
Contributor

Bughue commented Mar 20, 2022

方案上为什么不是对APPdata进行压缩，而是选择抛异常？

有道理，这种字符串的压缩率应该是很高的，这样的话在tc端存的就是个压缩值，压缩和解压都在客户端做。 @a364176773 一起看看？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bughue Bughue

Labels
good first issue Good for newcomers task: help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize: rm appdata size limit Bughue/seata
3 participants
@Bughue @funky-eyes @caohdgege