Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saga mode replay context lost start, issue 5682 reopen !! #6257

Closed
gou60 opened this issue Jan 12, 2024 · 5 comments · Fixed by #6465
Closed

saga mode replay context lost start, issue 5682 reopen !! #6257

gou60 opened this issue Jan 12, 2024 · 5 comments · Fixed by #6465
Assignees

Comments

@gou60
Copy link

gou60 commented Jan 12, 2024

Ⅰ. Issue Description

  • [#5682] 修复saga模式下replay context丢失startParams问题
    reopen!

Ⅱ. Describe what happened

https://github.com/apache/incubator-seata/blob/2.x/saga/seata-saga-engine/src/main/java/io/seata/saga/engine/impl/ProcessCtrlStateMachineEngine.java

protected Map<String, Object> replayContextVariables(StateMachineInstance stateMachineInstance) {
    Map<String, Object> contextVariables = new HashMap<>();
    **if (stateMachineInstance.getStartParams() == null) {**
        contextVariables.putAll(stateMachineInstance.getStartParams());
    }

Ⅲ. Describe what you expected to happen

https://github.com/apache/incubator-seata/blob/1.8.0/saga/seata-saga-engine/src/main/java/io/seata/saga/engine/impl/ProcessCtrlStateMachineEngine.java

protected Map<String, Object> replayContextVariables(StateMachineInstance stateMachineInstance) {
    Map<String, Object> contextVariables = new HashMap<>();
    **if (stateMachineInstance.getStartParams() != null) {**
        contextVariables.putAll(stateMachineInstance.getStartParams());
    }

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

@funky-eyes
Copy link
Contributor

@wt-better Please help with this question

@funky-eyes
Copy link
Contributor

What version of seata-client are you using?

@wt-better
Copy link
Contributor

this issue have fixed on 1.8, but not 2.x, I will fixed it on 2.x later.

@slievrly
Copy link
Member

@wt-better I suggest including it in the milestone for version 2.1.0.

@slievrly
Copy link
Member

@wt-better Is there any progress information here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants