Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QNN] Doc fix on convolution and dequantize #4799

Merged
merged 3 commits into from
Feb 3, 2020
Merged

Conversation

masahi
Copy link
Member

@masahi masahi commented Feb 1, 2020

cc @anijain2305 @vinx13 can you check if this change is correct? I'm a bit confused about input/output scale terminology.

I'm not completely sure if kernel_size is required, but I hit error if I leave it none.

@masahi
Copy link
Member Author

masahi commented Feb 1, 2020

this is the error I get if I leave out kernel_size:

  File "/home/masa/projects/dev/tvm/python/tvm/_ffi/_ctypes/function.py", line 72, in cfun
    rv = local_pyfunc(*pyargs)
  File "/home/masa/projects/dev/tvm/python/tvm/relay/op/nn/_nn.py", line 269, in alter_op_layout_conv2d
    return topi.nn.conv2d_alter_layout(attrs, inputs, tinfos, op)
  File "</home/masa/anaconda3/lib/python3.7/site-packages/decorator.py:decorator-gen-37>", line 2, in conv2d_alter_layout
  File "/home/masa/projects/dev/tvm/python/tvm/target.py", line 382, in dispatch_func
    return dispatch_dict[k](*args, **kwargs)
  File "/home/masa/projects/dev/tvm/topi/python/topi/x86/conv2d_alter_op.py", line 45, in _alter_conv2d_layout
    kh, kw = attrs.get_int_tuple("kernel_size")
  File "/home/masa/projects/dev/tvm/python/tvm/attrs.py", line 63, in get_int_tuple
    return tuple(x.value for x in self.__getattr__(key))
TypeError: 'NoneType' object is not iterable

Copy link
Contributor

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this :) LGTM

@vinx13 vinx13 merged commit 9963cf3 into apache:master Feb 3, 2020
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* QNN doc fix on conv and dequantize

* fix param name in tflite frontend

* make different fix
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* QNN doc fix on conv and dequantize

* fix param name in tflite frontend

* make different fix
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* QNN doc fix on conv and dequantize

* fix param name in tflite frontend

* make different fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants