[RELAY][FRONTEND][TENSORFLOW] Fix FuseBatchNorm output cast error if need_cast is True #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinthesun @FrozenGene can you please review this patch |
kevinthesun
reviewed
Feb 18, 2020
| @@ -897,6 +897,7 @@ def _impl(inputs, attr, params): | |||
| disables=['momentum'])(inputs, attr) | |||
|
|
|||
| if need_cast: | |||
| out = _expr.TupleGetItem(out.astuple(), 0) | |||
There was a problem hiding this comment.
Is this related to float16?
There was a problem hiding this comment.
I converted a float16 tf model containing the FusedBatchNorm operator.
For the float16 model, the output of the FusedBatchNorm layer is converted back to float16(there may be other quantization types).
But the FusedBatchNorm layer has 3 outputs, if passed directly to the Cast layer will cause an exception error.
So this modification only takes its first calculation output and passes it to the Cast
There was a problem hiding this comment.
It's true. I too see this recently and above change should fix it.
yhcvb
force-pushed
the
batchnorm_float16_cast_error
branch
from
9d1bb50
to
79204cb
Compare
yhcvb
changed the title
|
Thanks @yhcvb @srkreddy1238 |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.