[Relay][External Codegen] Support data types for CSourceModuleCodegen args and output #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiics
reviewed
Feb 24, 2020
| @@ -70,6 +72,12 @@ class CodegenC : public ExprVisitor, public CodegenCBase { | |||
| for (size_t i = 0; i < in_shape.size(); ++i) { | |||
| macro_stream << ", " << in_shape[i]; | |||
| } | |||
|
|
|||
| auto type_node = call->checked_type().as<TensorTypeNode>(); | |||
| @@ -116,29 +123,30 @@ class CodegenCBase { | |||
| * | |||
| * \endcode | |||
| */ | |||
| void GenerateBackendCFunc(const std::string& func_name, int arg_cnt) { | |||
| void GenerateBackendCFunc(const std::string& func_name, Array<Var> args, const Output& out) { | |||
| @@ -207,17 +215,20 @@ class CodegenCBase { | |||
| * | |||
| * \return The emitted code string. | |||
| */ | |||
| std::string JitImpl(std::string ext_func_id, std::vector<std::string> args, | |||
| std::string JitImpl(std::string ext_func_id, Array<Var> args, | |||
There was a problem hiding this comment.
please also use const reference here for all parameters.
| * | ||
| * \return The dtype string. | ||
| */ | ||
| std::string GetDtypeString(Var var) { |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
… args and output (apache#4934) * Support int args and no extra buffers * Fixes * remove testing code * fix style * more style * use const args * style Co-authored-by: Jon Soifer <[email protected]>
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
… args and output (apache#4934) * Support int args and no extra buffers * Fixes * remove testing code * fix style * more style * use const args * style Co-authored-by: Jon Soifer <[email protected]>
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
… args and output (apache#4934) * Support int args and no extra buffers * Fixes * remove testing code * fix style * more style * use const args * style Co-authored-by: Jon Soifer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a struct,
Output, to hold information about outputs forCSourceModuleCodegen. The codegen then uses this information to generate code with the correct datatype and copy it to the output buffer (if necessary).@comaniac @zhiics would you mind taking a look?
I added a unit test for dtype, but did not add a unit test for ignoring the
memcpy. I was having a hard time making the codegen code look clean.