[DOCS] Various sphinx related fix. #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tqchen
commented
Mar 29, 2020
tqchen
commented
- Use :ref: for reference.
- Use :py:class: to refer to API docs.
- Update installation guide to also refer to the download page.
- Only move html contents in doxygen.
- Use :ref: for reference. - Use :py:class: to refer to API docs. - Update installation guide to also refer to the download page. - Only move html contents in doxygen.
zhiics
reviewed
Mar 29, 2020
docs/install/docker.rst
Outdated
|
|
||
| Here the image-name can be a local docker image name, e.g. `tvm.ci_cpu` after you have done | ||
| the local build. Or a pre-built third party images (`tvmai/demo-cpu` or `tvmai/ci-gpu`). |
docs/install/docker.rst
Outdated
| @@ -67,7 +65,10 @@ Note that on macOS, because we use bridge network, jupyter notebook will be repo | |||
| at an URL like ``http://{container_hostname}:8888/?token=...``. You should replace the ``container_hostname`` | |||
| with ``localhost`` when pasting it into browser. | |||
|
|
|||
| You can find some un-official prebuilt images in `<https://hub.docker.com/r/tvmai/>`_. | |||
| Note that these are convenience images are not part of the ASF release. | |||
There was a problem hiding this comment.
Seems this sentence needs to be rephrased.
zhiics
approved these changes
Mar 29, 2020
yzhliu
approved these changes
Mar 29, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [DOCS] Various sphinx related fix. - Use :ref: for reference. - Use :py:class: to refer to API docs. - Update installation guide to also refer to the download page. - Only move html contents in doxygen. * Address review comments * Update wording
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [DOCS] Various sphinx related fix. - Use :ref: for reference. - Use :py:class: to refer to API docs. - Update installation guide to also refer to the download page. - Only move html contents in doxygen. * Address review comments * Update wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.