[MXNET]broadcast and logical op support #5461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siju-samuel
force-pushed
the
mxnet_broadcastops
branch
from
1f75e6a
to
47edd65
Compare
FrozenGene
reviewed
Apr 30, 2020
python/tvm/relay/frontend/mxnet.py
Outdated
|
|
||
| def _mx_broadcast_logical(logical_op): | ||
| def impl(inputs, input_types): | ||
| dtype0 = _infer_type(inputs[0]).checked_type.dtype |
There was a problem hiding this comment.
code style. MXNet frontend names the variable as dtype_0 style. Maybe we also could consider more meaningful name, like lhs_dtype.
FrozenGene
approved these changes
May 1, 2020
|
Thanks @siju-samuel |
Laurawly
pushed a commit
to Laurawly/tvm-1
that referenced
this pull request
May 9, 2020
* [MXNET]broadcast and logical op support * Review comment fixed
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 9, 2020
* [MXNET]broadcast and logical op support * Review comment fixed
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 18, 2020
* [MXNET]broadcast and logical op support * Review comment fixed
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 18, 2020
* [MXNET]broadcast and logical op support * Review comment fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@FrozenGene Please help me to review this frontend mxnet ops and merge.