[RUST][RUNTIME] Fix workspace #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhynes
approved these changes
May 4, 2020
rust/runtime/src/workspace.rs
Outdated
| if let Some(ws_idx) = ws_idx { | ||
| self.free.push(ws_idx); | ||
| } | ||
| let ws_idx = ws_idx.ok_or(format_err!("Invalid pointer"))?; |
There was a problem hiding this comment.
Suggested change
| let ws_idx = ws_idx.ok_or(format_err!("Invalid pointer"))?; | |
| let ws_idx = ws_idx.ok_or_else(|_| format_err!("Invalid pointer"))?; |
tqchen
approved these changes
May 4, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 9, 2020
* [RUST][RUNTIME] Fix workspace * use ok_or_else instead of ok_or
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 18, 2020
* [RUST][RUNTIME] Fix workspace * use ok_or_else instead of ok_or
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 18, 2020
* [RUST][RUNTIME] Fix workspace * use ok_or_else instead of ok_or
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!ws_size >= sizemeans(!ws_size) >= size, which is obviously wrong.@jroesch @nhynes @ehsanmok Please help to review.