LRN only supports 4D tensors, remove it from alter_op_layout #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoreau89
approved these changes
May 6, 2020
|
@merrymercy if you can review this change by the end of the day thanks! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 9, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Jun 18, 2020
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRN only supports 4D tensors, so we shouldn't propogate novel layouts through it. This change fixes crashes with a number of models in the ONNX Model Zoo that use LRN.
@merrymercy Git blame says you wrote this line 17 months ago, mind reviewing? Thanks!