Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend][MXNet] Support a few contrib ops in mxnet #5819

Merged
merged 4 commits into from
Jun 17, 2020

Conversation

icemelon
Copy link
Member

Thanks the help from @eric-haibin-lin.

@icemelon
Copy link
Member Author

@vinx13 @siju-samuel @kevinthesun @sxjscience Could you help take a look?

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the implementation + test cases and they look good.

Copy link
Member

@siju-samuel siju-samuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icemelon icemelon merged commit 3463528 into apache:master Jun 17, 2020
@icemelon icemelon deleted the mxops branch June 17, 2020 20:15
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 30, 2020
* support for bert in mxnet1.6 and gluonnlp0.9

* fix converter

* Add test cases

* add a todo
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Jul 2, 2020
* support for bert in mxnet1.6 and gluonnlp0.9

* fix converter

* Add test cases

* add a todo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants